Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report_to training arguments to control the integrations used #9735

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jan 21, 2021

What does this PR do?

This PR introduces a new report_to training argument that controls which of the multiple reporting tools to use in a training round. Currently, Trainer automatically uses everything installed, which can cause trouble when:

  • one platform is installed but not properly set up.
  • one platform is installed but the user doesn't want to use it today.

In my opinion the current behavior is too magical and does not fit our philosophy. To avoid any breaking change, the current default for this report_to argument is to use everything installed, but I would like to switch this to an empty list at the next major release, so the user has to opt-in the platforms they want to use.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM! Very clean.

@sgugger sgugger merged commit 82d46fe into master Jan 22, 2021
@sgugger sgugger deleted the non_magic_reporting branch January 22, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants